Repository navigation
fix: aggregation - #30
Merged
psincraian merged 2 commits intoNov 19, 2025
Merged
Conversation
- Add aggregation parameter (day/week/month) to custom events API endpoint - Implement aggregation logic in service layer for custom events - Add helper methods for weekly and monthly aggregation of custom events - Create comprehensive test suite (9 tests) for custom event aggregation - Ensure custom events are grouped by dashboard aggregation setting - All 18 aggregation tests pass (9 dashboard + 9 custom events) This allows users to view custom event data aggregated by day, week, or month, matching the behavior of regular analytics events.
The custom events timeseries API was not receiving the aggregation parameter from the frontend, causing it to always default to daily aggregation regardless of the user's selection. Changes: - Add aggregation parameter to custom events API call - Update chart time unit based on aggregation (day/week/month) - Dynamically adjust chart display format for different aggregations Now when users change the aggregation period, custom events will properly group by day, week, or month matching the regular events.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.