[codex] Add historical-roast command

[hu-po]

Summary

• add gpd:historical-roast as a project-aware command for source-backed in-character historical physicist roasts
• support one roaster spec argument that accepts either a single name or comma-separated panel
• add workflow docs, help/metadata surfaces, registry category, repo graph updates, and command tests

Validation

• uv run pytest -n 0 tests/core/test_historical_roast_command.py tests/test_command_boilerplate_cleanup.py tests/adapters/test_runtime_projected_command_requirement_coverage.py -q
• uv run pytest -n 0 tests/test_registry.py tests/core/test_command_help_metadata.py tests/adapters/test_runtime_projected_prompt_parity.py -q
• uv run pytest -n 0 tests/test_metadata_consistency.py tests/test_release_consistency.py -q
• uv run python scripts/sync_repo_graph_contract.py --check
• uv run python scripts/render_help_surface.py --check
• uv run python scripts/render_public_surface.py --check
• uv run python scripts/render_bootstrap_installer_metadata.py --check

Notes

Opened as draft from fork because hu-po does not have push access to psi-oss/get-physics-done.

Summary by CodeRabbit

• New Features

  • Introduced gpd:historical-roast command supporting single-physicist and comma-separated panel modes, producing per-physicist dossiers and a final roast/report.

• Documentation

  • Added detailed command reference and workflow docs with usage, examples, argument parsing, output layout, and requirements for source-backed dossiers.

• Tests

  • Added unit tests for command registration, prompt/workflow contracts, and updated prompt-budget and runtime-budget baselines.

• Chores

  • Updated repo graph and test metadata to include the new command.

[CLAassistant]

All committers have signed the CLA.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 4bb04e1f-05e4-484a-80ad-eec6c7292f8e

📥 Commits

Reviewing files that changed from the base of the PR and between 6ea789f and 43838e8.

📒 Files selected for processing (10)

• src/gpd/commands/historical-roast.md
• src/gpd/registry.py
• src/gpd/specs/references/help/detailed-command-reference.md
• src/gpd/specs/workflows/help.md
• src/gpd/specs/workflows/historical-roast.md
• tests/README.md
• tests/adapters/test_runtime_projection_diagnostics_budget.py
• tests/core/test_command_prompt_budget.py
• tests/core/test_historical_roast_command.py
• tests/repo_graph_contract.json

✅ Files skipped from review due to trivial changes (2)

• src/gpd/specs/references/help/detailed-command-reference.md
• src/gpd/specs/workflows/historical-roast.md

🚧 Files skipped from review as they are similar to previous changes (5)

• tests/repo_graph_contract.json
• tests/README.md
• src/gpd/registry.py
• src/gpd/specs/workflows/help.md
• tests/core/test_historical_roast_command.py

---

📝 Walkthrough

Walkthrough

Adds a new gpd:historical-roast command, its workflow spec, help docs, registry skill category, tests, and prompt/metadata budget updates for running source-backed historical-physicist roasts (single or comma-separated panel).

Changes

Historical-Roast Command Addition

Layer / File(s)	Summary
Command definition and execution contract src/gpd/commands/historical-roast.md	Command metadata and execution contract delegating parsing, dossier building, target resolution, output writing, and reporting to the historical-roast workflow; panel inferred from comma-separated names and --reviewer/--panel flags rejected.
Workflow specification and operational rules src/gpd/specs/workflows/historical-roast.md	Defines workflow purpose/boundaries (auxiliary roast, not peer-review), argument parsing and target detection rules, target resolution and extraction guidance, run/dossier/output layout with collision avoidance, per-physicist dossier protocol, voice constraints (no fabricated quotes/certainty), output structure for single vs panel modes, and final response contents.
Help and reference documentation src/gpd/specs/references/help/detailed-command-reference.md, src/gpd/specs/workflows/help.md	Adds command index and detailed reference entries documenting invocation syntax, examples, comma-separated panel behavior, and dossier prerequisites.
Skill category registration src/gpd/registry.py	Maps gpd-historical-roast to the paper skill category in the skill category map.
Tests, budgets, and repo metadata tests/core/test_historical_roast_command.py, tests/core/test_command_prompt_budget.py, tests/adapters/test_runtime_projection_diagnostics_budget.py, tests/README.md, tests/repo_graph_contract.json	Adds tests validating command registration and workflow/prompt contracts; updates command/workflow prompt baseline entries, runtime projection budget baseline, repo graph counts (commands 71→72, workflows 72→73), and prompt stem inventory.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

• cmaloney111

Poem

"I nibble notes and pen the roast,
A physicist's quirks I gently toast,
Panels comma-gathered, tidy and neat,
No fake quotes—just sourced and sweet,
🥕 Rabbit cheers the new command's feat."

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title '[codex] Add historical-roast command' directly and clearly describes the main change: adding a new command to the codebase.
Description check	✅ Passed	The description covers what changed (new command with single/panel support), provides comprehensive validation steps, but lacks explicit testing results and some template sections.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@tests/core/test_historical_roast_command.py`:
- Around line 43-46: The assertions in
tests/core/test_historical_roast_command.py are fragile because they match
strings containing embedded newlines from workflow_text; change them to assert
against whitespace-normalized text or against separate key phrases instead:
obtain a normalized string (e.g., collapse all whitespace in workflow_text or
replace newlines with spaces) and then assert that "does not write
`REFEREE-DECISION.json`", "GPD/historical-roast/{run-slug}/HISTORICAL-ROAST.md",
"Use `web_search`", and "Do not fabricate direct quotes" are present in that
normalized string (or assert each phrase separately) so tests no longer break on
simple rewrapping.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 3790a884-47d8-4346-a118-b4fb09c4e693

📥 Commits

Reviewing files that changed from the base of the PR and between 0f41769 and 6ea789f.

📒 Files selected for processing (8)

• src/gpd/commands/historical-roast.md
• src/gpd/registry.py
• src/gpd/specs/references/help/detailed-command-reference.md
• src/gpd/specs/workflows/help.md
• src/gpd/specs/workflows/historical-roast.md
• tests/README.md
• tests/core/test_historical_roast_command.py
• tests/repo_graph_contract.json

[marcpickett1]

🤖 RoastBot: Someone added a roast command to a physics research tool and I refuse to elaborate on what that says about all of us.