Skip to content

Fix inherited PR evidence and noisy command checks - #7

Merged
tabladrum merged 1 commit into
mainfrom
fix/pr-evidence-noise
Jun 14, 2026
Merged

tabladrum merged 1 commit into
mainfrom
fix/pr-evidence-noise

Conversation

@tabladrum

Copy link
Copy Markdown
Contributor

Summary

  • Load only shale YAML files that are present in the PR diff, so evidence inherited from the base branch is not rendered for branch-sync PRs.
  • Exclude base-branch/FETCH_HEAD sync history from git fallback file attribution.
  • Normalize command evidence before persistence and defensively clean historical command rows at render time.
  • Escape check-table code cells so shell pipelines cannot break Markdown table layout.

Fixes #6

Tests

  • go test ./...

@tabladrum
tabladrum merged commit 34421db into main Jun 14, 2026
4 checks passed
@tabladrum
tabladrum deleted the fix/pr-evidence-noise branch June 14, 2026 01:09
@tabladrum

Copy link
Copy Markdown
Contributor Author

Post-merge validation in provasign/shale-test-bed:

  • Branch-sync evidence scoping: Test Shale branch-sync evidence scoping shale-test-bed#5

    • Base branch already contained many existing .shale/*.yaml files.
    • Test PR added one README change plus one new evidence YAML.
    • Rendered Shale card showed Shale · 1 session and only README.md, confirming inherited base-branch evidence was not carried into the PR card.
  • Command-capture cleanup: Test Shale command capture cleanup shale-test-bed#6

    • Captured a noisy shell command containing a heredoc body, local absolute path, and go test ... | grep ... | head ... pipeline.
    • Persisted/rendered evidence kept only the meaningful check command.
    • Rendered checks table was not broken by pipe characters and did not include heredoc content, local paths, or grep/head filters.

Both validations used Shale v0.1.28 via provasign/shale-action@v1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Shale carries inherited evidence and noisy command captures into PR cards

1 participant