Repository navigation
rust: self-deref, f()? and expression receivers are not bare calls - #9
Merged
Merged
Conversation
…calls `(*self).find(..)`, `(**self).begin(..)`, `args.walk_builder()?.x()` and `dents[0].path_is_symlink()` arrived as bare calls. They are now `self`, `walk_builder()?` (the result after `?`) and `<expr>` (a method on an unnamed value); inside macros a call after `.` is `<expr>` too. grove's CI (no rust-analyzer) lost 41 true ripgrep edges when bare Rust calls were restricted to free functions; with this, recall is above baseline. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KXa6Cv1ZUXcdMqXcJfQFhX
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #8: receivers astkit could not name arrived as bare calls; grove's no-rust-analyzer ripgrep recall dropped when bare Rust calls were restricted to free functions. Now
self,f()?and<expr>. All 20 grove-eval oracles within baseline, ripgrep without rust-analyzer R .9055 (baseline .9047).🤖 Generated with Claude Code
https://claude.ai/code/session_01KXa6Cv1ZUXcdMqXcJfQFhX