Skip to content

feat(connector v3 docs): adds documentation of new v3 features#23

Open
gskapka wants to merge 18 commits into
masterfrom
feat/connector-v3-docs
Open

feat(connector v3 docs): adds documentation of new v3 features#23
gskapka wants to merge 18 commits into
masterfrom
feat/connector-v3-docs

Conversation

@gskapka

@gskapka gskapka commented May 23, 2019

Copy link
Copy Markdown

...PRd here for intial read-over/review by @D-Nice.

@gskapka gskapka requested a review from D-Nice May 23, 2019 18:15
@gskapka gskapka self-assigned this May 23, 2019

@D-Nice D-Nice left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comments need addressing

Comment thread source/includes/_ethereum.md Outdated
Comment thread source/includes/_ethereum.md Outdated
Comment thread source/includes/_ethereum.md
Comment thread source/includes/_ethereum.md Outdated
Comment thread source/includes/_ethereum.md Outdated
Comment thread source/includes/_ethereum.md
Comment thread source/includes/_ethereum.md

@D-Nice D-Nice left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's wait before merging until connector is live

@D-Nice

D-Nice commented Jun 10, 2019

Copy link
Copy Markdown

still LGTM

@riccardopersiani

Copy link
Copy Markdown

@gskapka, if not finished, I can review this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants