Promote / demote US roads

[wipfli]

Alternative solution to #422, fixes display fragmentation of roads around zoom 6 in the US.

Has not been tested yet. I will upload an archive later.

[bdon]

I think this solution is better than #422 since there are less vertices/features in the tiles.

[nvkelso]

I'm curious to see before / after / comparisons between the approaches :)

Alternative solution to #422, fixes display fragmentation of roads around zoom 6 in the US.

Is this because the style in the other PR needs a paired update?

I think this solution is better than #422 since there are less vertices/features in the tiles.

What's removing the vertices / features? Feature merging elsewhere?

[bdon]

Before:

After:

[nvkelso]

This smells like a styling issue where the major_roads are too faint compared with the highways.

Overzooming the images shows the same geometry vertexes are included in each before and after. The after draws them with a thinner styling.

Going with this this data hack approach risks either creating flicker on the next zooms in when the real raw classification is shown, or perpetuates the reclassification giving false impression of the road classes (sometimes ok if just for early zooms). Spice to taste.

[wipfli]

Here is a demo of the roads layer with the changes of this pull request:

https://maps.protomaps.com/#map=7.29/41.498/-88.041&theme=light&lang=en&tiles=https://protomaps.dev/~wipfli/promote-demote-us-roads.pmtiles&flavorName=light

[wipfli]

Before:

https://maps.protomaps.com/#map=7.29/41.498/-88.041&theme=light&lang=en&tiles=https://protomaps.dev/~wipfli/promote-demote-us-roads-main.pmtiles&flavorName=light

After:

https://maps.protomaps.com/#map=7.29/41.498/-88.041&theme=light&lang=en&tiles=https://protomaps.dev/~wipfli/promote-demote-us-roads.pmtiles&flavorName=light

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[wipfli]

I think styling the roads based on the kind attribute is the right thing to do. It represents the kind of road. Important ones show up earlier.
The highway tag in OpenStreetMap on the other hand represents more the class of road in the national network and not necessarily the importance of the road. For example in the US, if a highway=primary is part of the US:US network, then that road is more important than a highway=primary which is not part of any network. So the highway tag alone does not contain the full road importance...

[nvkelso]

No doubt it looks better at zoom 7! But by zoom 9 these roads should be showing their true colors. With this PR it looses detail at that zoom (and higher).

Before:

After: