Repository navigation
Resource detail drawer on click (config, history, actions) - #11
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the per-card action buttons with a right-hand detail drawer opened by
clicking a resource (card or graph node). The drawer shows desired vs observed
config, history, and actions.
Backend
GET /api/v1/resources/{kind}/{name}returns{ desiredYAML, observed }:desiredYAML: the matched manifest re-marshaled (uniform across kinds).observed: best-effort cluster state — VM/Template matched by vmid(present/cores/memory/cpu/running/ip/nameserver), ISO by presence.
ResourceDetailer(implemented by app), wired via server Options. Theobserve logic takes a small
clusterObserverinterface (unit-tested with a fake).Frontend
ResourceDetail.vue: a right drawer with header (name/kind/status), Desired(YAML block), Observed (key/values, "not present" when absent), History
timeline, and a Delete action (two-step confirm, ISO + VM).
stores/selection.tsholds the selected resource; the drawer fetchesdetail + events on open.
ResourceCardis now a click-to-select button; the trash and history buttonsare gone (they live in the drawer). Selected card gets a ring. Works in both the
card view and the graph (nodrag).
Tests
Non-goals
Live-streaming observed config, daemon-log lines in the drawer (separate logs
increment), editing from the panel.