Feat/room organization

.cargo/config.toml

@@ -3,3 +3,14 @@
 [target.'cfg(all())']
 rustflags = ["--cfg", "ruma_identifiers_storage=\"Arc\""]
 
+## Override the bundle/package ID that Makepad uses by default with Robrix's ID.
+[env]
+MAKEPAD_BUNDLE_IDENTIFIER = { value = "rs.robius.robrix", force = true }
+MAKEPAD_BUNDLE_NAME = { value = "Robrix", force = true }
+MAKEPAD_APP_ICON_32 = { value = "resources/icon_32.png", relative = true }
+MAKEPAD_APP_ICON_64 = { value = "resources/icon_64.png", relative = true }
+MAKEPAD_APP_ICON_128 = { value = "resources/icon_128.png", relative = true }
+MAKEPAD_APP_ICON_256 = { value = "resources/icon_256.png", relative = true }
+MAKEPAD_APP_ICON_512 = { value = "resources/icon_512.png", relative = true }
+MAKEPAD_APP_ICON_1024 = { value = "resources/icon_1024.png", relative = true }
+MAKEPAD_APP_ICON_ICO = { value = "resources/icon.ico", relative = true }

.claude/skills/file-issue/SKILL.md

@@ -0,0 +1,116 @@
+---
+name: file-issue
+description: Document a bug/fix locally in issues/ and create a matching GitHub issue
+allowed-tools:
+  - Bash(ls:*)
+  - Bash(mkdir:*)
+  - Bash(gh:*)
+  - Glob
+  - Grep
+  - Read
+  - Write
+when_to_use: |
+  Use when the user wants to document a discovered bug, applied fix, and remaining issues
+  as both a local issue file and a GitHub issue. Typically invoked after a debugging/fix session.
+  Examples: "file an issue for this", "record this bug", "create issue", "file-issue"
+---
+
+# File Issue
+
+Document a bug discovery and fix as a local issue file in `issues/` and a matching GitHub issue.
+All output is written in English regardless of conversation language.
+
+## Goal
+
+Produce two artifacts:
+1. A detailed local issue document at `issues/NNN-slug.md`
+2. A GitHub issue with a summary version
+
+## Steps
+
+### 1. Scan for next issue number
+
+Check if `issues/` directory exists in the project root. Create it if missing.
+List existing files to determine the next sequential number (e.g., if `001-*` exists, next is `002`).
+
+**Success criteria**: Know the next issue number (zero-padded to 3 digits) and confirmed `issues/` dir exists.
+
+### 2. Gather context from conversation
+
+Extract from the current conversation:
+- **Summary**: One-line description of the bug
+- **Severity**: Critical / High / Medium / Low
+- **Symptoms**: What the user observed (UI behavior, error messages, logs)
+- **Root Cause**: Technical explanation of why it happens
+- **Reproduction**: Steps to reproduce
+- **Fix Applied**: What was changed and why (include code snippets if relevant)
+- **Remaining Issues**: Known limitations, follow-up work, upstream bugs
+- **Files Changed**: List of modified files
+- **Test Verification**: Before/after comparison table
+
+Generate a kebab-case slug from the summary (e.g., `dock-load-state-drawlist-corruption`).
+
+**Success criteria**: All template sections populated with specific, accurate details from the session.
+
+### 3. Write local issue document
+
+Write to `issues/NNN-slug.md` using this template:
+
+```markdown
+# Issue #NNN: {Summary}
+
+**Date:** {YYYY-MM-DD}
+**Severity:** {Critical|High|Medium|Low}
+**Status:** Fixed (workaround applied) | Fixed | Open
+**Affected component:** {file path(s)}
+
+## Summary
+{One paragraph}
+
+## Symptoms
+{Bullet list of what the user observed}
+
+## Root Cause
+{Technical explanation with code snippets}
+
+## Reproduction
+{Numbered steps}
+
+## Fix Applied
+{Description + key code changes}
+
+## Remaining Issues
+{Numbered list of known limitations and follow-up work}
+
+## Files Changed
+{Bullet list}
+
+## Test Verification
+{Before/after table}
+```
+
+**Success criteria**: File written, all sections filled, no placeholder text remaining.
+
+### 4. Create GitHub issue
+
+Detect the repo with `gh repo view --json nameWithOwner`.
+Create a GitHub issue via `gh issue create` with:
+- Title: same as local doc summary (concise, under 80 chars)
+- Label: `bug`
+- Body: condensed version with Summary, Symptoms, Root Cause, Fix Applied, Remaining Issues (as checklist), and Environment section
+- Reference the local doc path in the body
+
+**Rules**:
+- Use a HEREDOC for the body to preserve formatting
+- Remaining Issues should be `- [ ]` checklist items
+- Include a link/reference to the local issue doc
+
+**Success criteria**: GitHub issue created, URL returned.
+
+### 5. Report results
+
+Tell the user:
+- Local issue doc path
+- GitHub issue URL (in `owner/repo#number` format for clickable link)
+
+**Success criteria**: Both paths reported in a concise summary.

.github/workflows/builds.yml

@@ -85,16 +85,16 @@ jobs:
             libwayland-dev libxkbcommon-dev
 
       - name: Install Rust
-        uses: dtolnay/rust-toolchain@stable
+        uses: actions-rust-lang/setup-rust-toolchain@v1
+        with:
+          rustflags: ""
 
       - name: Cache Rust dependencies
         uses: Swatinem/rust-cache@v2
         with:
           key: ubuntu-build-${{ hashFiles('Cargo.lock') }}
 
       - name: Build
-        env:
-          RUSTFLAGS: "-D warnings"
         run: |
           cargo build --profile fast
 
@@ -116,16 +116,16 @@ jobs:
       - uses: actions/checkout@v4
 
       - name: Install Rust
-        uses: dtolnay/rust-toolchain@stable
+        uses: actions-rust-lang/setup-rust-toolchain@v1
+        with:
+          rustflags: ""
 
       - name: Cache Rust dependencies
         uses: Swatinem/rust-cache@v2
         with:
           key: macos-${{ matrix.arch }}-build-${{ hashFiles('Cargo.lock') }}
 
       - name: Build
-        env:
-          RUSTFLAGS: "-D warnings"
         run: |
           cargo build --profile fast
 
@@ -140,16 +140,16 @@ jobs:
       - uses: actions/checkout@v4
 
       - name: Install Rust
-        uses: dtolnay/rust-toolchain@stable
+        uses: actions-rust-lang/setup-rust-toolchain@v1
+        with:
+          rustflags: ""
 
       - name: Cache Rust dependencies
         uses: Swatinem/rust-cache@v2
         with:
           key: windows-build-${{ hashFiles('Cargo.lock') }}
 
       - name: Build
-        env:
-          RUSTFLAGS: "-D warnings"
         run: |
           cargo build --profile fast
 
@@ -165,10 +165,10 @@ jobs:
     steps:
       - uses: actions/checkout@v4
 
-      - name: Install Rust stable and nightly
-        uses: dtolnay/rust-toolchain@stable
+      - name: Install Rust (pinned via rust-toolchain.toml)
+        uses: actions-rust-lang/setup-rust-toolchain@v1
         with:
-          toolchain: stable
+          rustflags: ""
 
       - name: Install Rust nightly
         run: |
@@ -192,7 +192,6 @@ jobs:
 
       - name: Build for iOS targets
         env:
-          RUSTFLAGS: "-D warnings"
           AWS_LC_SYS_CMAKE_BUILDER: 1
         run: |
           # Install iOS targets
@@ -217,7 +216,9 @@ jobs:
       - uses: actions/checkout@v4
 
       - name: Install Rust
-        uses: dtolnay/rust-toolchain@stable
+        uses: actions-rust-lang/setup-rust-toolchain@v1
+        with:
+          rustflags: ""
 
       - name: Setup cargo-makepad
         uses: ./.github/actions/setup-cargo-makepad
@@ -233,7 +234,6 @@ jobs:
 
       - name: Build Android APK
         env:
-          RUSTFLAGS: "-D warnings"
           AWS_LC_SYS_CMAKE_BUILDER: 1
         run: |
           cargo makepad android build -p robrix \
@@ -251,7 +251,9 @@ jobs:
       - uses: actions/checkout@v4
 
       - name: Install Rust
-        uses: dtolnay/rust-toolchain@stable
+        uses: actions-rust-lang/setup-rust-toolchain@v1
+        with:
+          rustflags: ""
 
       - name: Setup cargo-makepad
         uses: ./.github/actions/setup-cargo-makepad
@@ -267,7 +269,6 @@ jobs:
 
       - name: Build Android APK
         env:
-          RUSTFLAGS: "-D warnings"
           AWS_LC_SYS_CMAKE_BUILDER: 1
         run: |
           cargo makepad android build -p robrix \
@@ -288,7 +289,9 @@ jobs:
       - uses: actions/checkout@v4
 
       - name: Install Rust
-        uses: dtolnay/rust-toolchain@stable
+        uses: actions-rust-lang/setup-rust-toolchain@v1
+        with:
+          rustflags: ""
 
       - name: Cache Rust dependencies
         uses: Swatinem/rust-cache@v2
@@ -308,7 +311,6 @@ jobs:
 
       - name: Build Android APK
         env:
-          RUSTFLAGS: "-D warnings"
           AWS_LC_SYS_CMAKE_BUILDER: 1
           CMAKE_GENERATOR: Ninja
         run: |

.github/workflows/main.yml

@@ -40,8 +40,6 @@ env:
     CARGO_TERM_COLOR: always
     CARGO_INCREMENTAL: "0"  # Disable incremental compilation in CI
     RUST_BACKTRACE: 1
-    # Enable warnings as errors for strict checks
-    RUSTFLAGS: "-D warnings"
 
 jobs:
   clippy:
@@ -50,8 +48,9 @@ jobs:
     runs-on: macos-14  ## avoids having to install Linux deps
     steps:
       - uses: actions/checkout@v4
-      - uses: dtolnay/rust-toolchain@stable
+      - uses: actions-rust-lang/setup-rust-toolchain@v1
         with:
+          rustflags: ""
           components: rustfmt, clippy
       - uses: Swatinem/rust-cache@v2
         with:
@@ -67,3 +66,24 @@ jobs:
       - uses: actions/checkout@v4
       - name: Check for typos
         uses: crate-ci/typos@master
+
+  check_patches:
+    if: github.event.pull_request.draft == false
+    name: check patches
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - name: Forbid local path patches in Cargo.toml
+        # Local `path = ...` in a [patch.*] block is useful for upstream
+        # debugging but breaks CI and every teammate's checkout when
+        # accidentally committed. Upstream patches must use `git = ...`.
+        run: |
+          awk '
+            /^[[:space:]]*#/ {next}
+            /^[[:space:]]*\[patch/ {in_patch=1; next}
+            /^[[:space:]]*\[/ {in_patch=0}
+            in_patch && /path[[:space:]]*=/ {
+              print "::error file=Cargo.toml,line=" NR "::local path patch found: " $0
+              exit 1
+            }
+          ' Cargo.toml