feat(finance): watchlist 1/5/30-day % changes, ticker news + company info#112
Merged
Conversation
…info
- performance.ts: trailing 1/5/30-day % change helper (calendar-day lookback,
nearest-prior-trading-day; falls back to oldest bar on short history)
- /api/finance/watchlist/changes: per-profile changes endpoint (no fallback)
- finance-hub: 1D/5D/30D % on watchlist cards
- ticker view: 1D/5D/30D % in the price header, "About" company section,
and a /news-backed "News for {symbol}" section
- market-data: AssetInfo + optional getAsset() on the provider interface;
Alpaca implements it via the assets endpoint, Finnhub delegates to it
- /api/finance/asset: paid-gated, per-profile, read-through cached
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
vu1nz Security Review0 finding(s) in PR #? No security issues found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Builds on the watchlist sparklines branch with performance %, ticker news, and company info.
finance-hub) and the ticker chart header (ticker-view). New pure helperlib/finance/performance.ts(calendar-day lookback → nearest prior trading day; falls back to oldest bar on short history) + paid-gated/api/finance/watchlist/changesendpoint (per-profile provider, no Yahoo fallback).NewsSectioncomponent to add a/news-backed "News for {symbol}" section on the chart page (searched by symbol).AssetInfo+ optionalgetAsset()on the market-data provider interface; Alpaca implements it via the assets endpoint (name, exchange, class, status, tradability flags, options), Finnhub delegates to it. New paid-gated, cached/api/finance/assetroute. Rendered as company name/exchange in the header + an "About {symbol}" stats grid.Verification
tsc --noEmitcleangetAssetmapping (success / no-method / throws)Notes
/stock/profile2could supply those later if richer fundamentals are wanted.set-state-in-effectlint warnings; consistent with the file's existing effect pattern.🤖 Generated with Claude Code