fix(install): make install.sh POSIX-sh compatible#31
Merged
Conversation
The documented usage is `curl -fsSL https://c0upons.com/install.sh | sh`, but the script used bashisms (`set -o pipefail`, `echo -e`, `[[ ]]`, `&>`) so under dash/sh it failed immediately with `set: Illegal option -o pipefail`. Rewrite using only POSIX constructs: `set -eu`, `printf '%b'` instead of `echo -e`, `case` instead of `[[ ... == *..* ]]`, and `>/dev/null 2>&1`. Verified under `dash` and `sh`. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
vu1nz Security Review0 finding(s) in PR #? No security issues found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
curl -fsSL https://c0upons.com/install.sh | shfailed with:The script declared
#!/usr/bin/env bashbut the documented (and natural) invocation pipes it tosh(dash on Debian/Ubuntu), which ignores the shebang. It used several bashisms:set -o pipefail,echo -e,[[ ... ]],&>.Rewritten as POSIX sh:
set -eu,printf '%b',casefor PATH matching,>/dev/null 2>&1. Behavior preserved. Verified withdash -n/sh -nand a stubbed dry-run underdash.🤖 Generated with Claude Code