test(performance): allow RVF search setup to complete - #718
Merged
proffesor-for-testing merged 1 commit intoSep 27, 2026
Merged
proffesor-for-testing merged 1 commit into
proffesor-for-testing merged 1 commit into
Conversation
proffesor-for-testing
approved these changes
Sep 27, 2026
proffesor-for-testing
left a comment
Owner
There was a problem hiding this comment.
Thanks @rudycelekli — nicely scoped, and the linked #712 log backs it up exactly: search p95 was 0.40 ms and the only failure was setup running past Vitest's 10 s default. Raising the budget on just the combined test while keeping the strict < 10000 ms standalone ingest bound and p95 < 50 intact is the right trade. Verified locally (4/4 green) and CI is green.
Optional follow-up: logging the combined test's ingest duration would make future slow-runner diagnosis easier. Merging — thanks!
proffesor-for-testing
merged commit Sep 27, 2026
a49b603
into
proffesor-for-testing:main
18 checks passed
This was referenced Sep 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The native RVF Performance Gates job can fail while preparing the search-latency benchmark: it ingests 1,000 patterns before measuring search, and the setup exceeded Vitest's default 10-second per-test timeout on #712's CI run. That run measured search p95 at 0.40 ms, below the existing 50 ms search bound, but reported a timeout failure. The separate ingest benchmark passed at 7.75 seconds and retains its strict 10-second throughput bound.
Give only the combined ingest-and-search test a 30-second execution budget so it can complete setup and evaluate the existing search-latency assertion. Neither the ingest threshold nor the search threshold changes.
Verification
npm run typecheckandgit diff --checkpass.Failure modes
ingestMs < 10000, and the combined test keepsp95 < 50intests/performance/rvf-pattern-store.test.ts.Required check (issue #401)
Optional context
npm-publish.yml/tests/fixtures/init-corpus/: no