fix(ci): preserve reports without unauthorized fork PR comments - #701
Merged
proffesor-for-testing merged 1 commit intoSep 22, 2026
Conversation
This was referenced Sep 21, 2026
proffesor-for-testing
approved these changes
Sep 22, 2026
proffesor-for-testing
left a comment
Owner
There was a problem hiding this comment.
Reviewed the three workflow guards and the regression test; ran the test locally (12/12) and a Codex adversarial pass, which found no blocking defect in the added guards. The remaining unguarded write it noted (the dorny/test-reporter Checks step in mcp-tools-test.yml, already continue-on-error) is pre-existing and out of scope here.
proffesor-for-testing
merged commit Sep 22, 2026
94c52ca
into
proffesor-for-testing:main
20 checks passed
Owner
|
Thank you for this, @rudycelekli! Fork PRs were finishing their reports and then failing on the comment step with a 403; this guard keeps the dashboard, MCP summary, and Tier 3 skill gate running for contributors while only skipping the comment write, and the YAML-driven regression test makes sure the guard stays in place. Merged. |
Merged
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fork pull requests finish generating the test dashboard, then fail when its optional comment attempts to use the read-only workflow token (
Resource not accessible by integration, HTTP 403). This occurred on #696, #697, #698 and #699.Run comment steps only when the pull request's head repository matches the current repository. Apply the same guard to the MCP summary and skill-validation report, which contain the same unguarded write. Report generation, artifact uploads, test jobs and the Tier 3 failure gate remain active for fork contributions. Workflow triggers and token permissions are unchanged.
Verification
npx vitest run tests/unit/scripts/fork-pr-comments.test.ts --bail=0: 12 passed. The exact regression file against the original workflows produces 3 failed / 9 passed.go run github.com/rhysd/actionlint/cmd/actionlint@v1.7.12 -shellcheck= -pyflakes= .github/workflows/optimized-ci.yml .github/workflows/mcp-tools-test.yml .github/workflows/skill-validation.yml: passed. ShellCheck and Pyflakes integrations were disabled; Actions syntax, expressions and structure were checked.git -c core.whitespace=cr-at-eol diff --check: passed (the skill workflow already uses CRLF).0686b7cf: all GitHub checks pass. Full coverage executes 23,592 passing tests / 62 skipped, and the fork dashboard succeeds without attempting an unauthorized comment.Failure modes
Every failure mode mentioned in this PR description has either (a) a test that exercises it, or (b) a linked tracking issue.
Affects published API or CLI surface: no.
Touches the init flow / npm-publish workflow / init corpus: no.