Better SubBladeWithList by NoSloppy · Pull Request #894 · profezzorn/ProffieOS

NoSloppy · 2026-09-08T03:52:43Z

I will update the POD if/when this is approved.

Basically, this update allows the user to avoid needing to fill out the SubBladeWithList with a "dummy" blade definition containing all the non-targeted pixels.
So for example, if you only want to light up 3 pixels anywhere along a 95 pixel blade, instead of needing to do the current requirement of:

#define NUM_BLADES 2

// preset with an extra "dummy" blade style here
{ "font", "track",
StylePtr<......>(),
StylePtr<Black>()  // <--- dummy
}

// blade array with tediously long dummy definition 
{ 0,
  SubBladeWithList<19, 34, 49>(WS281XBladePtr<95, bladePin, Color8::GRB, PowerPINS<bladePowerPin2, bladePowerPin3> >() ),
  SubBladeWithList<0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,  20,21,22,23,24,25,26,27,28,29,30,31,32,33,  35,36,37,38,39,40,41,42,43,44,45,46,47,48,  50,51,52,53,54,55,56,57,58,59,60,61,62,63,64,65,66,67,68,69,70,71,72,73,74,75,76,77,78,79,80,81,82,83,84,85,86,87,88,89,90,91,92,93,94>(NULL),

  CONFIGARRAY(presets) }
  }

It can now just be

#define NUM_BLADES 1

{ "font", "track",
StylePtr<......>(),
}

{ 0,
SubBladeWithList<19, 34, 49>(WS281XBladePtr<95, bladePin, Color8::GRB, PowerPINS<bladePowerPin2, bladePowerPin3> >() ),
 CONFIGARRAY(presets) }
}

Tested and working well.

Updated comments and functionality for the detonator buttons, including new features like mute and countdown timer sound.

Reset Variation on Off(). Clean up unused bools.

Semi final bc detonator buttons

Updated comments

fix boom

Make smoothswings swapping better when Alt is switched. (profezzorn#893)

Updated comments for clarity and corrected logic in IsHandled method.

NoSloppy · 2026-09-08T04:47:14Z

  }
  bool IsHandled(HandledFeature effect) override {
-    if (current_style_)
+    if (!current_style_)


This was inverted and I guess just went unnoticed for a long time.

Fix should be in a separate PR.

profezzorn

I think this could be a one-liner....

profezzorn · 2026-09-08T05:04:06Z

+NUM_BLADES is 1 in this example, and the style sees a blade with three LEDs.
+Note that LED addresses start at zero, so LED 20 is index 19.
+
+That means you do NOT HAVE to list all the LEDs you don't want in an extra


We don't need to document the things you don't have to do.

profezzorn · 2026-09-08T05:06:35Z

    blade = first_subblade_wrapper->blade_;
  }

+  // Negative indices are allowed, they just mean that the LED goes nowhere.


This comment doesn't match the code.

More clear now?

profezzorn · 2026-09-08T05:13:31Z

+    // addresses a few of the LEDs. That way the LEDs which aren't part of any
+    // sub-blade end up dark instead of showing whatever happened to be in the
+    // frame buffer already.
+    if (blank_unused_leds_) blade_->clear();


The if statement is redundant. (because Run() is only called once per subblade group.)
I think the comment is not very helpful.
Maybe say something like:

Without clearing the blade, pixels which aren't part of any subblade will get random values.

I assume you meant the comment is redundant, and that the code is fine, hence the comment suggestion?
I changed it to // Without clearing the blade, pixels which aren't part of any subblade may get random values.
Better?

No, I meant the if statement is redundant, just "blade_->clear();" should be enough.

I see. Yes it is. Edited.

profezzorn · 2026-09-10T06:53:19Z

+  // list, so any LED which isn't part of some sub-blade has to be turned off
+  // explicitly. This is set on the primary sub-blade, which is the one that
+  // runs all the styles in the chain.
+  void SetBlankUnusedLeds() {


This is no longer needed.

profezzorn · 2026-09-10T06:55:15Z

 Usage: SubBladeWithList<int1, int2, ...>(blade_definition)
 Like SubBlade, but you provide a custom list of LED indices instead of a range.
 Useful for ring-based or irregular LED layouts.
+The style only sees the LEDs in the list, and every LED of the underlying blade


This is a long and weird comment, why not just say:

Pixels wrapped into a subblade, but not referenced by any subblade will be black.

profezzorn · 2026-09-10T06:56:42Z

    blade = first_subblade_wrapper->blade_;
  }

+  // Unmapped LEDs are allowed; a negative mapping means that this


This should be done at compilation time.

profezzorn · 2026-09-10T06:56:56Z

  ret->SetupSubBlade(blade, 0, count);
+  // first_subblade_wrapper is the primary sub-blade of this chain, and the
+  // one which gets to blank out the LEDs that this list doesn't cover.
+  first_subblade_wrapper->SetBlankUnusedLeds();


No longer needed.

profezzorn · 2026-09-10T06:57:06Z

  SubBladeWrapper* next_;
  int blade_number_;
  bool primary_ = false;
+  bool blank_unused_leds_ = false;


No longer needed.

NoSloppy added 23 commits August 19, 2026 23:14

Add files via upload

717c508

Update detonator_BC_buttons.h with new features

2bcb271

Enhance detonator_BC_buttons.h with new features

265a332

Updated comments and functionality for the detonator buttons, including new features like mute and countdown timer sound.

Update detonator_BC_buttons.h with new features

2c7dac1

Update detonator_BC_buttons.h with new comments

5578996

Merge pull request #5 from NoSloppy/add-stab-as-clash

1da3a75

Reset Variation on Off(). Clean up unused bools.

Add files via upload

d0667cc

Add files via upload

8b7f0a6

Add files via upload

d613512

Merge pull request #6 from NoSloppy/semi-final-BC-Detonator-buttons

b79de48

Semi final bc detonator buttons

pdated comments

6de8241

Updated comments

Add files via upload

7273f64

remove fix attempt

d9536d9

indention

1a1f96a

fix boom

6c8d73f

Merge pull request #7 from NoSloppy/update-detonatorBC

984f64d

fix boom

better alt switching

cf00b10

Merge pull request #9 from profezzorn/master

a9082b2

Make smoothswings swapping better when Alt is switched. (profezzorn#893)

Delete config/KR_TD_configBC.h

2a58d82

Delete config/KR_TD_configBC_saberTest.h

67f431b

Delete props/detonator_BC_buttons.h

5e3ed95

Add files via upload

7a2c667

fix IsHandled logic

485ea3a

Updated comments for clarity and corrected logic in IsHandled method.

NoSloppy commented Sep 8, 2026

View reviewed changes

NoSloppy added 2 commits September 8, 2026 01:03

revert fix and new PR instead

651546c

revert indent fixes and move to other PR

fe4475a

profezzorn reviewed Sep 8, 2026

View reviewed changes

NoSloppy added 3 commits September 8, 2026 23:31

remove superfluous usage text

3ebe790

Clarify comment re: negative LED mappings

42544b7

edit comment

581c2e9

NoSloppy added 3 commits September 8, 2026 23:50

Fix typo

65079b0

actually fix typo

6368dcd

remove if condition from blade_->clear() in run()

a2a4cb9

profezzorn reviewed Sep 10, 2026

View reviewed changes

Conversation

NoSloppy commented Sep 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

profezzorn left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

NoSloppy commented Sep 8, 2026 •

edited

Loading