Skip to content

Keep the Android feed logo fallback icon visible in dark mode #1569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
prof18 merged 1 commit into from
Oct 27, 2026
Merged

Keep the Android feed logo fallback icon visible in dark mode #1569

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 31 additions & 12 deletions androidApp/src/main/kotlin/com/prof18/feedflow/android/ui/components/FeedSourceLogoImage.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,21 +2,28 @@ package com.prof18.feedflow.android.ui.components

import androidx.compose.foundation.background
import androidx.compose.foundation.layout.Box
import androidx.compose.foundation.layout.fillMaxSize
import androidx.compose.foundation.layout.size
import androidx.compose.foundation.shape.RoundedCornerShape
import androidx.compose.material.icons.Icons
import androidx.compose.material.icons.filled.Category
import androidx.compose.material3.Icon
import androidx.compose.runtime.Composable
import androidx.compose.runtime.getValue
import androidx.compose.runtime.mutableStateOf
import androidx.compose.runtime.remember
import androidx.compose.runtime.setValue
import androidx.compose.ui.Alignment
import androidx.compose.ui.Modifier
import androidx.compose.ui.draw.clip
import androidx.compose.ui.graphics.Color
import androidx.compose.ui.graphics.vector.ImageVector
import androidx.compose.ui.graphics.vector.rememberVectorPainter
import androidx.compose.ui.layout.ContentScale
import androidx.compose.ui.platform.LocalDensity
import androidx.compose.ui.platform.LocalInspectionMode
import androidx.compose.ui.unit.Dp
import coil3.compose.AsyncImage
import coil3.compose.AsyncImagePainter
import coil3.compose.LocalPlatformContext
import coil3.request.ImageRequest
import com.prof18.feedflow.android.ui.style.Spacing
Expand All @@ -37,19 +44,31 @@ fun FeedSourceLogoImage(
)
} else {
val density = LocalDensity.current
AsyncImage(
model = ImageRequest.Builder(LocalPlatformContext.current)
.data(imageUrl)
.size(with(density) { size.roundToPx() })
.build(),
placeholder = rememberVectorPainter(fallbackIcon),
fallback = rememberVectorPainter(fallbackIcon),
error = rememberVectorPainter(fallbackIcon),
contentDescription = null,
contentScale = ContentScale.Crop,
// The fallback is drawn as a tinted Icon instead of an AsyncImage placeholder painter,
// which would render the vector untinted (black) and disappear on dark backgrounds.
var showFallback by remember(imageUrl) { mutableStateOf(true) }
Box(
modifier = modifier
.size(size)
.clip(RoundedCornerShape(cornerRadius)),
)
contentAlignment = Alignment.Center,
) {
AsyncImage(
model = ImageRequest.Builder(LocalPlatformContext.current)
.data(imageUrl)
.size(with(density) { size.roundToPx() })
.build(),
onState = { showFallback = it !is AsyncImagePainter.State.Success },
contentDescription = null,
contentScale = ContentScale.Crop,
modifier = Modifier.fillMaxSize(),
)
if (showFallback) {
Icon(
imageVector = fallbackIcon,
contentDescription = null,
)
}
}
}
}
Loading