POCD-348 fix: add success copy fallback - #210
Merged
Merged
Conversation
jakubjasinsky
requested changes
Jul 30, 2025
| { | ||
| "name": "processout.js", | ||
| "version": "1.2.6", | ||
| "version": "1.2.7", |
Collaborator
There was a problem hiding this comment.
Please rebase current master as I bumped version an hour ago
edwin-joseph-cko
force-pushed
the
fix/POCD-348-add-success-copy-fallback
branch
from
July 30, 2025 08:50
db04713 to
88b4b2c
Compare
jakubjasinsky
approved these changes
Jul 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR enhances the APM success page to provide more appropriate messaging based on whether an invoice is present in the configuration. Currently, the success page always shows "Payment approved!" and payment amount, which may not be appropriate for all APM flows.
Solution
Changes Made:
src/apm/views/Success.tsto conditionally render title and descriptionDemo
The success page now displays:
Checklist
yarn bump-versionNotes
This change improves the user experience by providing contextually appropriate messaging for different APM payment flows, particularly useful for flows that don't involve a traditional invoice.
Jira Issue
POCD-348