Skip to content

POCD-348 fix: add success copy fallback - #210

Merged
edwin-joseph-cko merged 2 commits into
masterfrom
fix/POCD-348-add-success-copy-fallback
Jul 30, 2025
Merged

POCD-348 fix: add success copy fallback#210
edwin-joseph-cko merged 2 commits into
masterfrom
fix/POCD-348-add-success-copy-fallback

Conversation

@edwin-joseph-cko

@edwin-joseph-cko edwin-joseph-cko commented Jul 29, 2025

Copy link
Copy Markdown
Contributor

Description

This PR enhances the APM success page to provide more appropriate messaging based on whether an invoice is present in the configuration. Currently, the success page always shows "Payment approved!" and payment amount, which may not be appropriate for all APM flows.

Solution

  • Dynamic title: Shows "Payment approved!" when invoice is present, "You're all set!" when no invoice
  • Conditional description: Only shows payment amount when invoice is present
  • Improved UX: Provides more appropriate messaging for different APM scenarios

Changes Made:

  • Updated src/apm/views/Success.ts to conditionally render title and description
  • Added logic to check for invoice presence in configuration
  • Maintained existing functionality while adding flexibility for different APM flows

Demo

The success page now displays:

  • With invoice: "Payment approved!" + payment amount
  • Without invoice: "You're all set!" (no amount shown)

Checklist

  • I bumped the version of the project using yarn bump-version
  • I have checked the code for any potential issues
  • I tested my changes in the browser

Notes

This change improves the user experience by providing contextually appropriate messaging for different APM payment flows, particularly useful for flows that don't involve a traditional invoice.

Jira Issue

POCD-348

Comment thread package.json Outdated
{
"name": "processout.js",
"version": "1.2.6",
"version": "1.2.7",

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase current master as I bumped version an hour ago

@edwin-joseph-cko
edwin-joseph-cko force-pushed the fix/POCD-348-add-success-copy-fallback branch from db04713 to 88b4b2c Compare July 30, 2025 08:50
@edwin-joseph-cko
edwin-joseph-cko merged commit 9312ffa into master Jul 30, 2025
5 checks passed
@edwin-joseph-cko
edwin-joseph-cko deleted the fix/POCD-348-add-success-copy-fallback branch July 30, 2025 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants