-
Notifications
You must be signed in to change notification settings - Fork 2.5k
TML-3229: register the Mongo attribute namespace and diagnose unknown attributes #30160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
StevenMcClankerton
wants to merge
8
commits into
main
Choose a base branch
from
tml-3229-mongo-attributes-registered
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
187c64e
TML-3229: open the mongo-attributes-registered slice (spec, plan)
SevInf 017f171
TML-3229: register every Mongo built-in in one attribute-spec namespace
SevInf 17b1936
TML-3229: contribute the Mongo attribute namespace from the family de…
SevInf a92e096
TML-3229: diagnose Mongo attribute names outside the registered names…
SevInf 3b5e110
TML-3229: record the mongo-attributes-registered slice close in the p…
SevInf 0d66460
TML-3229: expose the family attribute namespace through the erased co…
SevInf 3151fb0
TML-3229: record the slice-close dispatch in the project trace
SevInf cfe56a4
TML-3229: hint at deletion for never-lowered Mongo attributes and rec…
SevInf File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win
Reject registered attributes where their semantics cannot apply.
Lines 135-145 treat every registered field attribute as valid on composite-type fields. A schema such as
type Address { code String@unique}produces no diagnostic, but composite processing emits no unique index.@idhas the same problem.@uniqueon relation fields is also skipped bycollectIndexes.Restrict composite-type fields to supported attributes, or emit an attribute diagnostic for
@id,@unique, and@relationin those contexts. Reject@uniquewhen the field is a relation.🤖 Prompt for AI Agents