Improve react typescript compatibility

[bvella]

No description provided.

[bvella]

Fixed #1930

[bvella]

For clarity, I am trying to get an existing react project working with preact. I encountered a number of typescript incompatibilities as described in #1930 and attempted to fix them with the proposed changes.

I added the following in my tsconfig.json:

{
  "compilerOptions": {
    ...
    "paths": {
      "react": ["node_modules/preact/compat/"],
      "react-dom": ["node_modules/preact/compat/"]
    }
  }
}

And in package.json applied a browserify global transform using aliasify to alias react and react-dom to preact/compat.

[coveralls]

Coverage remained the same at 99.798% when pulling 770ac20 on bvella:improve-react-ts-compat into 020d5e5 on preactjs:master.

[bvella]

Incorporated #2150 (comment)

[ForsakenHarmony]

I know it's been a while, there are some more types missing in #2414 if you want to add those

[brookback]

Any chance this could be merged? 👼

[ForsakenHarmony]

I think this broke typescript before

preactjs/preact-cli#1030

[bvella]

In what way? I skimmed through the referenced issue but did not understand how this breaks typescript. This file declares the JSX namespace, without which, typescript does not process jsx. This is also the same way react itself exports the JSX namespace

[toniopelo]

When using @apollo/client

ERROR in ./node_modules/@apollo/client/react/context/ApolloConsumer.d.ts(4,55):
TS2694: Namespace 'React' has no exported member 'ReactChild'.

I wasn't using this branch though, but I guess you need to add ReactChild too ?

[dgreene1]

@bvella could you update this branch with the base branch so it can be re-approved and then released?

[evenfrost]

Any update on this? Is there a complete workaround with all the changes needed to perform to a Preact project to be able to use typed React libraries in it until it merged?

[matthias-ccri]

I would like to contribute to this effort.. I'm not sure how to do it besides creating a separate PR. Is that ok?