Skip to content

feat(metadata): dispatch metadata.fetch to one named source #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mkoushni wants to merge 2 commits into
base: main
Choose a base branch
from
+893 −75
Open

feat(metadata): dispatch metadata.fetch to one named source #281

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
153790b
feat(ws): review fix
mkoushni Oct 25, 2026
1aa2a9f
fix: address clippy redundant closure warnings and format code
mkoushni Oct 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
263 changes: 192 additions & 71 deletions crates/ppe-core/src/engine.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
// config. Trust flows:
// config loader → engine → PluginRef → executor

use std::borrow::Cow;
use std::hash::{Hash, Hasher};
use std::path::Path;
use std::sync::atomic::{AtomicBool, AtomicU64, AtomicUsize, Ordering};
Expand Down Expand Up @@ -65,6 +66,24 @@ pub const VIOLATION_ASSERTION_MISSING: &str = "auth.assertion_missing";
/// deny: the request never reached a rule.
pub const VIOLATION_UNIDENTIFIED_REQUEST: &str = "unidentified_request";

fn entries_for_target<'a>(
entries: &'a [crate::registry::HookEntry],
payload: &dyn PluginPayload,
) -> Cow<'a, [crate::registry::HookEntry]> {
payload.target_plugin().map_or_else(
|| Cow::Borrowed(entries),
|target| {
Cow::Owned(
entries
.iter()
.filter(|entry| entry.plugin_ref.name() == target)
.cloned()
.collect(),
)
},
)
}

/// Why a request could not be resolved against the route table.
///
/// Resolving no route is not an error: the request falls back to the global
Expand Down Expand Up @@ -2266,13 +2285,38 @@ impl PolicyEngine {
// change our view mid-pipeline.
let snapshot = self.load_runtime();
let hook_type = HookType::new(hook_name);
let all_entries = snapshot.registry.entries_for_hook(&hook_type);
let hook_entries = snapshot.registry.entries_for_hook(&hook_type);
let targeted_entries = entries_for_target(hook_entries, payload.as_ref());

if targeted_entries.is_empty()
&& let Some(target) = payload.target_plugin().map(ToOwned::to_owned)
{
let violation = crate::error::PluginViolation::new(
"plugin.not_found",
format!("hook '{hook_name}' has no registered plugin instance named '{target}'"),
);
return (
self.finish(
&snapshot,
Some(hook_name),
None,
Some(payload),
PipelineResult::denied(
violation,
extensions,
context_table.unwrap_or_default(),
),
)
.await,
BackgroundTasks::empty(),
);
}

// Same caveat as `invoke_named`: route annotations can produce a
// dispatch entry without any plugin being registered on the
// hook directly, so we can only short-circuit when both the
// registry and the annotation map are empty.
if all_entries.is_empty() && snapshot.route_annotations.is_empty() {
if targeted_entries.is_empty() && snapshot.route_annotations.is_empty() {
// Route filtering has not run, so the route is resolved here: a
// contract written on a route holds whether or not this hook has a
// plugin on it.
Expand All @@ -2294,27 +2338,35 @@ impl PolicyEngine {
);
}

let (entries, matched) = match self
.filter_entries_by_route(&snapshot, all_entries, &extensions, hook_name)
.await
{
Ok(resolved) => resolved,
Err(cause) => {
return (
self.finish(
&snapshot,
Some(hook_name),
None,
Some(payload),
PipelineResult::denied(
cause.violation(),
extensions,
context_table.unwrap_or_default(),
),
)
.await,
BackgroundTasks::empty(),
);
let (entries, matched) = match targeted_entries {
// The caller already selected this semantic operation's one source.
// Policy-mode route resolution deliberately returns no ordinary
// plugin chain, so applying it here would discard the target.
Cow::Owned(owned) => (Arc::new(owned), None),
Cow::Borrowed(all_entries) => {
match self
.filter_entries_by_route(&snapshot, all_entries, &extensions, hook_name)
.await
{
Ok(resolved) => resolved,
Err(cause) => {
return (
self.finish(
&snapshot,
Some(hook_name),
None,
Some(payload),
PipelineResult::denied(
cause.violation(),
extensions,
context_table.unwrap_or_default(),
),
)
.await,
BackgroundTasks::empty(),
);
},
}
},
};
if entries.is_empty() {
Expand Down Expand Up @@ -2396,12 +2448,40 @@ impl PolicyEngine {
) -> (PipelineResult, BackgroundTasks) {
let snapshot = self.load_runtime();
let hook_type = HookType::new(H::NAME);
let all_entries = snapshot.registry.entries_for_hook(&hook_type);
let hook_entries = snapshot.registry.entries_for_hook(&hook_type);
let targeted_entries = entries_for_target(hook_entries, &payload);

if targeted_entries.is_empty()
&& let Some(target) = payload.target_plugin().map(ToOwned::to_owned)
{
let violation = crate::error::PluginViolation::new(
"plugin.not_found",
format!(
"hook '{}' has no registered plugin instance named '{target}'",
H::NAME
),
);
return (
self.finish(
&snapshot,
Some(H::NAME),
None,
Some(Box::new(payload)),
PipelineResult::denied(
violation,
extensions,
context_table.unwrap_or_default(),
),
)
.await,
BackgroundTasks::empty(),
);
}

// See `invoke_named` for why we don't short-circuit on
// `all_entries.is_empty()` alone — route annotations can fire
// `targeted_entries.is_empty()` alone — route annotations can fire
// without a directly-registered plugin.
if all_entries.is_empty() && snapshot.route_annotations.is_empty() {
if targeted_entries.is_empty() && snapshot.route_annotations.is_empty() {
let boxed: Box<dyn PluginPayload> = Box::new(payload);
let matched = resolve_contract_route(&snapshot, &extensions);
return (
Expand All @@ -2421,27 +2501,35 @@ impl PolicyEngine {
);
}

let (entries, matched) = match self
.filter_entries_by_route(&snapshot, all_entries, &extensions, H::NAME)
.await
{
Ok(resolved) => resolved,
Err(cause) => {
return (
self.finish(
&snapshot,
Some(H::NAME),
None,
Some(Box::new(payload)),
PipelineResult::denied(
cause.violation(),
extensions,
context_table.unwrap_or_default(),
),
)
.await,
BackgroundTasks::empty(),
);
let (entries, matched) = match targeted_entries {
// A targeted semantic operation is already fully resolved by its
// payload and must not be replaced by a route annotation or the
// policy mode's intentionally empty ordinary plugin chain.
Cow::Owned(owned) => (Arc::new(owned), None),
Cow::Borrowed(all_entries) => {
match self
.filter_entries_by_route(&snapshot, all_entries, &extensions, H::NAME)
.await
{
Ok(resolved) => resolved,
Err(cause) => {
return (
self.finish(
&snapshot,
Some(H::NAME),
None,
Some(Box::new(payload)),
PipelineResult::denied(
cause.violation(),
extensions,
context_table.unwrap_or_default(),
),
)
.await,
BackgroundTasks::empty(),
);
},
}
},
};
if entries.is_empty() {
Expand Down Expand Up @@ -2522,19 +2610,44 @@ impl PolicyEngine {
) -> (PipelineResult, BackgroundTasks) {
let snapshot = self.load_runtime();
let hook_type = HookType::new(hook_name);
let all_entries = snapshot.registry.entries_for_hook(&hook_type);
let hook_entries = snapshot.registry.entries_for_hook(&hook_type);
let targeted_entries = entries_for_target(hook_entries, &payload);

if targeted_entries.is_empty()
&& let Some(target) = payload.target_plugin().map(ToOwned::to_owned)
{
let violation = crate::error::PluginViolation::new(
"plugin.not_found",
format!("hook '{hook_name}' has no registered plugin instance named '{target}'"),
);
return (
self.finish(
&snapshot,
Some(hook_name),
None,
Some(Box::new(payload)),
PipelineResult::denied(
violation,
extensions,
context_table.unwrap_or_default(),
),
)
.await,
BackgroundTasks::empty(),
);
}

// No registered entries AND no route annotations → nothing to
// do. Allow-and-pass-through. We can't short-circuit on
// `all_entries.is_empty()` alone, because route annotations
// `targeted_entries.is_empty()` alone, because route annotations
// (external-orchestrator handlers from APL / future Rego /
// Cedar-direct) can produce a single-entry dispatch even when
// no plugin was registered on the hook directly.
//
// Returning here also means a request whose path cannot be read is
// allowed rather than denied on such a hook. Nothing would have
// enforced on it either way.
if all_entries.is_empty() && snapshot.route_annotations.is_empty() {
if targeted_entries.is_empty() && snapshot.route_annotations.is_empty() {
let boxed: Box<dyn PluginPayload> = Box::new(payload);
let matched = resolve_contract_route(&snapshot, &extensions);
return (
Expand All @@ -2554,27 +2667,35 @@ impl PolicyEngine {
);
}

let (entries, matched) = match self
.filter_entries_by_route(&snapshot, all_entries, &extensions, hook_name)
.await
{
Ok(resolved) => resolved,
Err(cause) => {
return (
self.finish(
&snapshot,
Some(hook_name),
None,
Some(Box::new(payload)),
PipelineResult::denied(
cause.violation(),
extensions,
context_table.unwrap_or_default(),
),
)
.await,
BackgroundTasks::empty(),
);
let (entries, matched) = match targeted_entries {
// The policy evaluator chose this source by instance name. Route
// filtering governs lifecycle hooks; it must not erase or replace
// an already-resolved semantic operation.
Cow::Owned(owned) => (Arc::new(owned), None),
Cow::Borrowed(all_entries) => {
match self
.filter_entries_by_route(&snapshot, all_entries, &extensions, hook_name)
.await
{
Ok(resolved) => resolved,
Err(cause) => {
return (
self.finish(
&snapshot,
Some(hook_name),
None,
Some(Box::new(payload)),
PipelineResult::denied(
cause.violation(),
extensions,
context_table.unwrap_or_default(),
),
)
.await,
BackgroundTasks::empty(),
);
},
}
},
};
if entries.is_empty() {
Expand Down
Loading