fixed best_delta to initialise based on the shape of delta, not the shape of the input samples - #180
Open
andreybarsky wants to merge 1 commit into
Open
Conversation
…hape of the input samples
Collaborator
|
Checking with @zangobot if this breaks anything in his domain 🧱 |
Contributor
|
In the other libraries that use secml-torch, we have re-defined some of those. So it seems legit to me. |
Collaborator
|
The pipeline failed as setuptools broke some things. @andreybarsky, you should be able to pull from main and merge the fixing changes, and that should fix the CI pipeline execution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small bugfix but helps for the case where the perturbation being optimised does not have the same dimensions as the original input itself (e.g. when you are optimising a kernel that is convolved with the input to create the adversarial image)