Rebase - #26
Merged
Merged
Conversation
The #else stub implementations for Accessory, Characteristic, and Service did not conform to HomeKitDescribable or provide the required properties, which would break compilation on non-HomeKit platforms. https://claude.ai/code/session_016TjqsNiRBkhaxyrksWzYeU
- Fix hashFiles('**/Package.resolved') failure on Linux: Package.resolved
is gitignored, causing the cache step to crash in containers. Use
Package.swift instead, which always exists and drives the dependency graph.
- Rewrite codegen sanity check to avoid pipefail issues: use `shell: bash {0}`
(no implicit set -eo pipefail), capture exit codes explicitly, and write
diff output to a temp file instead of piping through grep chains.
- Fix uniqueIdentifier in platform stubs: change from computed property
returning UUID() (new value each access) to stored `let` property
initialized once per instance, matching protocol semantics.
https://claude.ai/code/session_016TjqsNiRBkhaxyrksWzYeU
Use git diff --name-only + grep instead of pathspec exclusion to avoid potential shell quoting issues. Add git status and diff --stat output to identify exactly which files change after the generator runs. https://claude.ai/code/session_016TjqsNiRBkhaxyrksWzYeU
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.