fix: disable multi-tab on Safari regardless of mobile or desktop - #63
Merged
Conversation
Safari aggressively suspends background tabs, which breaks the shared worker coordination between tabs. Multi-tab enablement now lives in a single isMultiTabEnabled() helper (SharedWorker available and not Safari) used by both pickVFS and the PowerSyncDatabase flags, so the logged multiTab value always matches the actual flag. The IndexedDB fallback condition simplifies to all Safari, since desktop Safari's tab suspension can strand OPFS locks even with multi-tab disabled. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Safari aggressively suspends background tabs, which breaks the shared worker coordination between tabs. Multi-tab enablement now lives in a single isMultiTabEnabled() helper (SharedWorker available and not Safari) used by both pickVFS and the PowerSyncDatabase flags, so the logged multiTab value always matches the actual flag. The IndexedDB fallback condition simplifies to all Safari, since desktop Safari's tab suspension can strand OPFS locks even with multi-tab disabled.
These changes were made in collaboration with Claude Opus 4.8