Skip to content

Test PR: Removed problematic code.#66

Open
aweneer wants to merge 1 commit intomasterfrom
aweneer-patch-1
Open

Test PR: Removed problematic code.#66
aweneer wants to merge 1 commit intomasterfrom
aweneer-patch-1

Conversation

@aweneer
Copy link
Copy Markdown
Contributor

@aweneer aweneer commented Aug 29, 2022

Test

TestCommenter
TestCommenter reviewed Aug 29, 2022
View reviewed changes
Comment thread Build.ps1
@@ -1,8 +1,3 @@
if ( $env:VisualStudioVersion -eq $null ) {
Copy link
Copy Markdown

@TestCommenter TestCommenter Aug 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works for me, I don't see why would it need to be removed.

TestCommenter
TestCommenter reviewed Aug 29, 2022
View reviewed changes
Comment thread Build.ps1

(& dotnet nuget locals http-cache -c) | Out-Null
& dotnet run --project "$PSScriptRoot\eng\src\BuildGitHubTestProduct.csproj" -- $args
exit $LASTEXITCODE
Copy link
Copy Markdown

@TestCommenter TestCommenter Aug 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test: maybe keep

@PostSharpBot
Copy link
Copy Markdown
Member

PostSharpBot commented Aug 29, 2022

Hello @TestCommenter, thank you for submitting this pull request review. We will try to get back to you as soon as possible.
Note to the PostSharp team, this ticket is being tracked in our dashboard under ID TP-30992.

TestCommenter
TestCommenter reviewed Aug 29, 2022
View reviewed changes
Comment thread Build.ps1
}

(& dotnet nuget locals http-cache -c) | Out-Null
& dotnet run --project "$PSScriptRoot\eng\src\BuildGitHubTestProduct.csproj" -- $args
Copy link
Copy Markdown

@TestCommenter TestCommenter Aug 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test: Ok. Good change

@PostSharpBot
Copy link
Copy Markdown
Member

PostSharpBot commented Aug 29, 2022

Hello @TestCommenter, thank you for submitting this pull request review. We will try to get back to you as soon as possible.
Note to the PostSharp team, this ticket is being tracked in our dashboard under ID TP-30997.

TestCommenter
TestCommenter reviewed Aug 29, 2022
View reviewed changes
Comment thread Build.ps1
}

(& dotnet nuget locals http-cache -c) | Out-Null
& dotnet run --project "$PSScriptRoot\eng\src\BuildGitHubTestProduct.csproj" -- $args
Copy link
Copy Markdown

@TestCommenter TestCommenter Aug 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TEST review

@PostSharpBot
Copy link
Copy Markdown
Member

PostSharpBot commented Aug 29, 2022

Hello @TestCommenter, thank you for submitting this pull request review. We will try to get back to you as soon as possible.
Note to the PostSharp team, this ticket is being tracked in our dashboard under ID TP-30999.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@TestCommenter TestCommenter TestCommenter left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aweneer @PostSharpBot @TestCommenter