Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Truncated DNS headers raise struct.error in the discovery protocol handlers. Ignore these malformed replies before changing response counters or per-host discovery state, then continue processing valid responses.
The multicast handler also avoids creating empty host entries for replies with no services or only unrelated services.
Fixes #2703.
Validation on this branch with Python 3.12 in Docker (
--network none):The tests send synthetic packets followed by valid replies. No Apple TV or Home Assistant instance was used. The outer receive delegate already catches exceptions; this fixes malformed-packet handling and logging, not a demonstrated process crash.