Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The AirPlay remote control connection wraps authentication failures in ProtocolError, so callers cannot distinguish rejected credentials from a malformed protocol response. Preserve AuthenticationError, InvalidCredentialsError, NoCredentialsError, and BackOffError from session connection and remote control setup.
Regression tests cover both stages, retain HTTP 470 handling, and verify that missing Salt and invalid response bodies still become protocol errors. All 159 AirPlay and facade tests pass. Black, isort, flake8, pylint, and the API documentation check pass.
Related to home-assistant/core#183182. This complements #2920, which decodes explicit pairing error TLVs; it does not duplicate that decoder or infer a password requirement from missing Salt. No HomePod hardware validation is claimed.