Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Send
volume_upandvolume_downthroughAudio, and supportturn_onandturn_offthroughPower. The volume commands currently call the deprecated remote-control methods, and power commands fall through as unsupported on the current branch.Keep the existing JSON response format and remote buttons. Dispatch only these four no-argument commands so Audio/Power properties and methods that require arguments are not exposed accidentally.
Validation: all 24 script tests pass, including nine dispatch/output cases. The four affected commands fail their new tests before this change. Black, isort, flake8 and pydocstyle pass for the changed code.
Fixes #2782.
Additional validation: the full suite with the related pyatv patches applied passes (1,292 passed, 5 skipped). The formatting, lint, spelling and typing checks from chickn pass. Generated API-documentation verification produces the same pre-existing mismatch on the base revision.