Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correct the data length fields for tags
0x93and0x94to four and eight bytes, including the little-endian examples. Also correct the tag bytes in the0x63and0x64string examples.The text distinguishes these data widths from the linear string widths currently implemented by pyatv. No encoder or decoder behavior changes.
Validation: all 41 existing OPACK tests pass, and all eight documented string/data examples decode to the stated value with no remainder.
Fixes #2779.
Additional validation: the full suite with the related pyatv patches applied passes (1,292 passed, 5 skipped). The formatting, lint, spelling and typing checks from chickn pass. Generated API-documentation verification produces the same pre-existing mismatch on the base revision.