fix: report query_time in microseconds to match PgBouncer#952
Open
SAY-5 wants to merge 1 commit into
Open
Conversation
SHOW STATS reported total_query_time and avg_query_time in milliseconds while PgBouncer reports the same fields in microseconds. Change the elapsed duration calculation from as_millis() to as_micros() so the values are consistent with PgBouncer and with wait_time, which was already stored in microseconds. Fixes postgresml#810 Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #810.
Problem
SHOW STATSreportedtotal_query_timeandavg_query_timein milliseconds while PgBouncer reports the same fields in microseconds. After a 1-secondSELECT pg_sleep(1), PgCat showedtotal_query_time = 1001while PgBouncer showed1007496.wait_timewas already stored in microseconds (viaas_micros()inpool.rs), so this was an inconsistency within PgCat itself as well.Fix
Change the elapsed-time calculation in
src/client.rsfrom.as_millis()to.as_micros()when callingserver.stats().query(...). Update the parameter name inServerStats::query()frommillisecondstomicrosecondsto match.Two files changed, three lines:
src/client.rs:as_millis()->as_micros()src/stats/server.rs: renamemillisecondsparam tomicrosecondsVerification
cargo buildpasses with no new warningscargo clippypasses (pre-existing unrelated warning only)cargo fmtproduces no changesas_millis()would restore the wrong-unit values; the commit restores the correct behaviour