Shut down help proxy when help comm drops#1285
Merged
Merged
Conversation
thomasp85
approved these changes
Jul 2, 2026
thomasp85
left a comment
thomasp85
left a comment
Collaborator
There was a problem hiding this comment.
This LGTM - it feels like a pretty clean fix to a non-issue (but issue none-the-less)
lionel-
force-pushed
the
task/help-proxy-lifecycle
branch
from
ca25739 to
415f057
Compare
lionel-
force-pushed
the
task/sync-help-comm
branch
from
01b14a1 to
b6b06b6
Compare
lionel-
force-pushed
the
task/help-proxy-lifecycle
branch
from
415f057 to
c3f3578
Compare
lionel-
force-pushed
the
task/sync-help-comm
branch
2 times, most recently
from
660d83b to
d90d95f
Compare
lionel-
force-pushed
the
task/help-proxy-lifecycle
branch
2 times, most recently
from
929e8c2 to
6d33b3b
Compare
lionel-
force-pushed
the
task/help-proxy-lifecycle
branch
from
6d33b3b to
775190e
Compare
lionel-
added a commit
to posit-dev/positron
that referenced
this pull request
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Branched from #1284
While working on that PR I noticed that we never shut down the proxy server when the Help comm is tore down. If we start a new one, we'd pile up a new proxy.
This is theoretical because Help is one of the comms that the frontend reuses on refresh/reload (unlike the UI comm). But it still seems nice to handle the shutdown path properly. Covered by a new test.