feat(port-ocean): derive ingestUrl from baseUrl when unset - #285
Open
haimn-support wants to merge 1 commit into
Open
feat(port-ocean): derive ingestUrl from baseUrl when unset#285haimn-support wants to merge 1 commit into
haimn-support wants to merge 1 commit into
Conversation
Previously port.ingestUrl defaulted to https://ingest.getport.io and had to be set manually for non-default regions (e.g. US). It now defaults to empty and is derived from port.baseUrl by replacing the `api.` host prefix with `ingest.` (https://api.us.getport.io -> https://ingest.us.getport.io), so a single baseUrl change is enough to point a deployment at the right region. An explicit port.ingestUrl still overrides the derivation. Bumps chart to 0.18.0. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously port.ingestUrl defaulted to https://ingest.getport.io and had to be set manually for non-default regions (e.g. US). It now defaults to empty and is derived from port.baseUrl by replacing the
api.host prefix withingest.(https://api.us.getport.io -> https://ingest.us.getport.io), so a single baseUrl change is enough to point a deployment at the right region. An explicit port.ingestUrl still overrides the derivation. Bumps chart to 0.18.0.Description
What - Add a mechanism to calculate ingestUrl by using the baseUrl
Why - To eliminate the need to add another mandatory param and avoid issues where the baseUrl and ingestUrl mismatch
How - Previously port.ingestUrl defaulted to https://ingest.getport.io and had to be set manually for non-default regions (e.g. US). It now defaults to empty and is derived from port.baseUrl by replacing the
api.host prefix withingest.(https://api.us.getport.io -> https://ingest.us.getport.io), so a single baseUrl change is enough to point a deployment at the right region. An explicit port.ingestUrl still overrides the derivation.Type of change
Please leave one option from the following and delete the rest: