paper: JOSS prep — ORCIDs, refs, acknowledgements, affiliations - #28
Merged
Conversation
- Fill in ORCIDs for Chase, Atul, and Sasha; add Atul's extra affiliations (Convergence Institute, EE, DSAI Institute) per PR #24 - Add NIH (R01CA138264, U01CA212007), NSF (2527296) grant numbers to acknowledgements - Cite Sove2020 and Wang2025 in the QSP intro per Sasha's edits - Cite Gong2021 and RuizMartinez2022 as the spQSP framework lineage that qsp-codegen extracts from - Drop "stiff" qualifier from the MATLAB-integrator critique - Bump date to 18 May 2026 - .gitignore: ignore generated paper artifacts and uv.lock Placeholder commented-out author entries for Chang Gong and Alvaro Ruiz-Martinez left in YAML pending Sasha's reply on coauthor invitations.
…ff ORCIDs Decision: Gong and Ruiz-Martinez are not coauthors (kept as Gong2021/ RuizMartinez2022 lineage citations). Fill remaining ORCIDs in CITATION.cff for Chase, Atul, and Sasha.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JOSS submission prep, consolidating Sasha's emailed edits, Atul's PR #24, and a few cleanups.
0000-0003-2395-4408), Atul (0000-0001-5144-6924), Sasha (0000-0002-6706-9235)Sove2020,Wang2025(cited in QSP intro), andGong2021,RuizMartinez2022(cited as the spQSP framework lineage that qsp-codegen extracts from).gitignore: ignore generated paper artifacts (*.html,*.pdf,paper_files/) anduv.lockHolding the merge — pending Sasha's reply on whether Chang Gong / Alvaro Ruiz-Martinez should be invited as coauthors (placeholder YAML comments left in
paper/paper.md). Once resolved, this PR also makes #24 redundant.All
paper.bibentries pass the reference validator against Crossref except for benign diacritic/double-barreled-surname normalizations and the Wang2025 online-first-year vs print-year discrepancy.