fix(cal): bounded-observable logit_normal validator + n_biological_is_floor prompt - #76
Merged
Merged
Conversation
…ical_is_floor Parity with the SubmodelTarget bounded-observable validator: CalibrationTarget reuses the shared ObservedDistribution, and the cal prompt already instructs shape=logit_normal for [0,1] observables, but nothing enforced it. Add the same check on CalibrationTargetEstimates (bounded units + moments shape normal/lognormal -> require logit_normal). Also surface n_biological_is_floor (already available via the shared ObservedDistribution) in the cal authoring prompt for 'n>=' sources.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends the 0.8.1 statistical-model hardening to the CalibrationTarget side, which reuses the same
ObservedDistribution.CalibrationTargetEstimatesnow rejects apercent/fraction/proportion/probabilityobservable whosemoments-formobserved_distributionusesshape: normal/lognormal— parity with the submodelvalidate_bounded_observable_uses_logit_normal. The cal prompt already instructedlogit_normalfor bounded observables; nothing enforced it.n_biological_is_floor(already usable on cal via the sharedObservedDistribution) in the population-spread section for "n≥" sources.R1 (SEM-scale double-encode) has no cal analog to add — the cal side already has
validate_observed_distribution_consistency. V-A (un-clipped normal crossing zero) applies only to samplingdistribution_codes; our cal targets are declarative, so it's deferred.