fix(submodel): allow 1.645 as an observation_code constant - #75
Merged
Conversation
The authoring prompt instructs 1.645 (normal z for the 5th-95th percentile range) for reconstructing an SD from box-plot whiskers, but the hardcoded-value validator only whitelisted 1.96 (2.5th-97.5th), so a literal 1.645 was rejected as a hardcoded value. Add 1.645 alongside 1.96 in ALLOWED_CONSTANTS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 0.8.1 authoring prompt tells authors to use
1.645(normal z for the 5th–95th percentile range) when reconstructing an SD from box-plot whiskers, butALLOWED_CONSTANTSonly whitelisted1.96(2.5th–97.5th) — so a literal1.645failedvalidate_no_hardcoded_values_in_observation_code. This adds1.645alongside1.96, closing the prompt/validator inconsistency introduced in #74.