diag(safety): attribute lockstep mismatches; time NVS flushes - #154
Merged
Merged
Claude / Claude Code Review
completed
Sep 20, 2026 in 21m 5s
Code review found 2 new issues (1 earlier finding still open)
Found 5 candidates, confirmed 3: 2 posted in this review, 1 from earlier reviews still open. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 3 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | firmware/components/dcs_support/src/dcs_nvs.c:56 |
Operators reading /state.json's nvs_dcs max (g_dcs_nvs_write_max) can see a lower 'worst NVS write this boot' than actua |
| 🟡 Nit | firmware/components/dcs_support/src/dcs_nvs.c:568 |
dcs_nvs_migrate_legacy_operators() nests a second timed NVS handle inside its own, so operators can see g_dcs_nvs_write_ |
Loading