Skip to content

feat: report modification-control findings - #139

Open
rajasimman-madhivanan wants to merge 2 commits into
change-0002-wire-breakfrom
change-0002-change-control-warn
Open

rajasimman-madhivanan wants to merge 2 commits into
change-0002-wire-breakfrom
change-0002-change-control-warn

test: align checker tests with repository hooks

c166738
Select commit
Loading
Failed to load commit list.
Claude / Claude Code Review completed Sep 21, 2026 in 18m 36s

Code review found 2 new issues (9 earlier findings still open)

Found 5 candidates, confirmed 11: 2 posted in this review, 9 from earlier reviews still open. See review comments for details.

Details

Severity Count
🔴 Important 3
🟡 Nit 8
🟣 Pre-existing 0
Severity File:Line Issue
🟡 Nit tools/change_control/checks.py:249 Maintainers can get an E1 'authorized before implementation' pass even though the real authorization was added long afte
🟡 Nit tools/change_control/checks.py:157 An authorizer who explicitly declines a Change Request is still counted as having authorized it, so E1 reports 'authoriz