Skip to content

Remove Option.FromBoolean and fix its calls on the compile error too #1039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FreeApophis wants to merge 1 commit into from
Open

Remove Option.FromBoolean and fix its calls on the compile error too #1039

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions Documentation/src/option.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,9 @@ Option<string> name = user.HasName.Then(() => user.Name); // the select
Option<IFormFile> file = request.HasFormContentType.Then(() => request.Form.Files.FirstOrNone()); // flattening
```

`Option.FromBoolean`, the previous form of this, is obsolete since 3.8.0 and will be removed in 4.0.0. The
`Funcky.Analyzers` package offers a code fix for the obsoletion warning that rewrites it to `Then`.
`Option.FromBoolean`, the previous form of this, was obsoleted in 3.8.0 and removed in 4.0.0. The `Funcky.Analyzers`
package offers a code fix that rewrites it to `Then`, both for the obsoletion warning on 3.8.0 and for the compile
error CS0117 the removed member leaves behind on 4.0.0, so the upgrade can go first and the rewrite second.

The type parameter is constrained to `notnull`. An `Option<string?>` does not exist, because "absent" is what `None`
is for. `Option.FromNullable` is the bridge: it maps `null` to `None` and anything else to `Some`.
Expand Down
267 changes: 223 additions & 44 deletions Funcky.Analyzers/Funcky.Analyzers.CodeFixes/OptionFromBooleanCodeFix.cs
View file
Open in desktop

Large diffs are not rendered by default.

Loading
Loading