Repository navigation
Build the analyzers and the source generator against Roslyn 4.14 - #1038
Open
FreeApophis wants to merge 1 commit into
Open
FreeApophis wants to merge 1 commit into
FreeApophis wants to merge 1 commit into
Conversation
Funcky 4 no longer supports SDKs before .NET 10, so the built-in analyzers, Funcky.Analyzers and the internal source generator move to one Roslyn 4.14 baseline (Visual Studio 2022 17.14, .NET SDK 9.0.300). The Roslyn 3.7 asset of the built-in analyzers and its ROSLYN_4_4_0 guard are removed, together with the release tracking workaround only that project needed. The Funcky package targets now remove all built-in analyzers on SDKs without analyzer versioning, as a single asset cannot be partially kept. Funcky.Analyzers becomes 3.0.0. Closes #814 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #814.
Funcky 4.0.0 drops support for SDKs before .NET 10 (grooming decision of 21 Oct 2026), so every Roslyn component in the repo moves to the single baseline Roslyn 4.14 (Visual Studio 2022 17.14 / .NET SDK 9.0.300, hence every .NET 10 SDK):
Funcky.Analyzers,Funcky.Analyzers.CodeFixes,Funcky.BuiltinAnalyzers,Funcky.BuiltinAnalyzers.CodeFixes:AnalyzerRoslynVersion4.4.0 → 4.14.0.Funcky.Analyzersbecomes 3.0.0.Funcky.SourceGenerator(internal, builds Funcky itself): 4.12.0 → 4.14.0. It already usesForAttributeWithMetadataName.Roslyn3.7projects of the built-in analyzers are deleted (also fromFuncky.slnxandFuncky.csproj), the#if ROSLYN_4_4_0guard around λ1010 is gone, and theDisableAnalyzerReleaseTrackingworkaround that only those projects needed is removed from the targets.Funcky/build/Funcky.targets: with one asset there is nothing to keep on SDKs without analyzer versioning, so the target now removes all built-in analyzers there (silently; the library keeps working).Funcky.Analyzerskeeps its warning λ.BUILD.0001 with the new version text.Funcky.Analyzers/readme.md, the rules table (λ1010 note dropped),SupportPolicy.mdgains an SDK section, changelog entry under 4.0.0.Note on the issue's wording: Roslyn 4.14 is the compiler of SDK 9.0.300, not 10.0.100 (that one ships Roslyn 5.0). 4.14 was the groomed choice and it covers all .NET 10 SDKs plus the last VS 2022 release.
Verified locally:
dotnet build Funcky.slnx -c Releasewith 0 warnings, Funcky.Analyzers.Test (248) and Funcky.SourceGenerator.Test (11) pass, and both packed packages contain exactlyanalyzers/dotnet/roslyn4.14/cs.🤖 Generated with Claude Code