Repository navigation
Drop the net7.0, net6.0, net5.0 and netcoreapp3.1 target frameworks - #1037
Open
FreeApophis wants to merge 1 commit into
Open
FreeApophis wants to merge 1 commit into
FreeApophis wants to merge 1 commit into
Conversation
The removal SupportPolicy.md announced for Funcky 4: all four are out of Microsoft's support. Funcky ships net11.0 down to net8.0 plus the two netstandard assets, Funcky.Async drops net5.0, and Funcky.Xunit and Funcky.Xunit.v3 replace net6.0 with net8.0. With net8.0 as the oldest .NET asset, the feature constant groups for netcoreapp3.0, net5.0, net6.0 and net7.0 collapse into one net8.0 group (the constants themselves stay, since the netstandard assets still lack those features), the trim analyzer exemption for the .NET 6 and 7 targeting packs goes, the netcoreapp3.1 cases in the public API targets and the System.Text.Json reference go, and the four PublicAPI folders are deleted. Package validation now compares netstandard2.1 directly with net8.0, so the compatibility suppressions for the members the source generator only emits on newer frameworks move to that pair. Closes #1032 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This was referenced Oct 30, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1032. The first mechanical breaking change of 4.0.0 (umbrella #1035): the removal that
SupportPolicy.mdannounced for Funcky 4.Assets per package after this PR
Consumers on a removed framework fall back to the
netstandard2.1asset (ornetstandard2.0below .NET Core 3.0) and lose the members that need a newer base class library; the changelog entry lists the notable ones.Changes
IsTrimmable,EnableTrimAnalyzerandIsAotCompatiblenow hang on onenet8.0condition, and the exemption of the .NET 6 and 7 ILLink analyzers (which threw on extension blocks) is gone with those targets. Thenetcoreapp3.1case of theSystem.Text.Jsonreference goes.FrameworkFeatureConstants.props: the netcoreapp3.0, net5.0, net6.0 and net7.0 groups collapse into the net8.0 group. The constants themselves stay, because the netstandard assets still lack those features, so no#ifin the sources changes.PublicAPI: the net5.0, net6.0, net7.0 and netcoreapp3.1 folders of Funcky are deleted;PublicApiAnalyzers.targetsdrops the netcoreapp3.1 case of the RS0041 exemption.CompatibilitySuppressions.xml: package validation compares neighbouring assets, so netstandard2.1 is now next to net8.0. The suppressions for the members the source generator emits only on newer frameworks (Chunk(int),ParseEnumOrNone,ParseCacheControlHeaderValueOrNone) move to that pair; the file was regenerated by ApiCompat and contains the same members as before.SupportPolicy.md: the removed frameworks move to a done section, and the next candidates (net8.0, net9.0, both out of support by the 4.0.0 release) are named for Funcky 5.net8.0as the Funcky.Xunit.v3 target.Verification
dotnet build Funcky.slnx -c Release -warnaserror: clean.dotnet test: green on every remaining framework (net11.0 to net8.0, net48).dotnet packwith package validation enabled: all five packages pack with the assets in the table above and no API compatibility errors.🤖 Generated with Claude Code