Repository navigation
Accept xUnit.net v3 1.x through 4.x in Funcky.Xunit.v3 - #1028
Merged
Merged
Conversation
The package was pinned to xunit.v3 [1.0.1, 2) although nothing it uses (Assert, XunitException, ArgumentFormatter, IXunitSerializer, SerializationHelper) changed in the 2.0, 3.0 and 4.0 releases; the breaking changes there are in the runner and extensibility pipeline. The range is now [1.0.1, 5), still compiled against 1.0.1, and the test suite passes against 4.0.2 at runtime. The xunit chapter gains a compatibility table with the test host and runner requirements of each xunit.v3 major, including the VSTest opt-in needed on the .NET 10 SDK with 4.x. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
JudoJosef
approved these changes
Oct 29, 2026
This was referenced Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1015, the non-breaking slice that fits 3.8.0.
Changes
xunit.v3.assertandxunit.v3.extensibility.coreare now[1.0.1, 5)instead of[1.0.1, 2). The package is still compiled against 1.0.1, so the lower bound and the public API are unchanged.mtp-offpackages for VSTest.Stacked on #1024 because the table lives in that chapter.
Why this is safe
Everything Funcky.Xunit.v3 touches is in
xunit.v3.assertandxunit.v3.extensibility.core:Assert,XunitException,ArgumentFormatter.Format,IXunitSerializer,IRegisterXunitSerializerAttributeandSerializationHelper.Instance. None of these appear in the breaking-change lists of 2.0.0, 3.0.0 or 4.0.0, and both packages still shipnetstandard2.0in 4.x.Verification
Funcky.Xunit.v3.Testwith the library built against 1.0.1 andxunit.v34.0.2 at runtime: 59 passed, 0 failed (net10.0, viadotnet run --project).-warnaserrorclean, 59 passed.Left on #1015
🤖 Generated with Claude Code