Skip to content

Add build script and air formatting - #22

Open
nadinehussein wants to merge 3 commits into
mainfrom
add-build-script
Open

nadinehussein wants to merge 3 commits into
mainfrom
add-build-script

Conversation

@nadinehussein

Copy link
Copy Markdown
Member

added new build script and air formatting before fixing tests to resolve RCMD check failures

Comment thread README.md
str(flob)
#> List of 1
#> $ /Library/Frameworks/R.framework/Versions/4.5-arm64/Resources/library/flobr/extdata/flobr.pdf: raw [1:133851] 58 0a 00 00 ...
#> $ /private/var/folders/s3/3cc1k9p13mjgrqj490hdxl6w0000gn/T/RtmpeVHiSB/temp_libpath12f6ca5a5baa/flobr/extdata/flobr.pdf: raw [1:133851] 58 0a 00 00 ...

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems wrong

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the devtools::build_readme() in the build script installs into a temporary library so the path gets changed each time. I can switch back to

rmarkdown::render("README.Rmd", output_format = "github_document") ?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think switching back is probably better

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants