Add tests for gsdd() and gdd() with truncated second season - #46
Merged
Merged
Conversation
Document that a year with one complete and one truncated growing season returns NA rather than the sum of the complete seasons. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds snapshot tests documenting that
gsdd()andgdd()returnNAfor a year when one of the growing seasons is truncated, even if another season in that year is complete.The tests mirror the existing
gss()truncation test: the two-seasontemperature2series is blanked from 2019-08-28 onward so the second season is truncated at the end.🤖 Generated with Claude Code