podman ps: allow sorting by pod (finishes #13033's --sort half) - #29637
Open
ROKUMATE wants to merge 2 commits into
Open
podman ps: allow sorting by pod (finishes #13033's --sort half)#29637ROKUMATE wants to merge 2 commits into
ROKUMATE wants to merge 2 commits into
Conversation
Contributor
Author
|
@Honny1 yeahh checked it ... was now thinking to implement the left part of it ... also will change the pr description from removing to adding a complete feature of --sort=pod from the issue you mentioned |
ROKUMATE
force-pushed
the
remove-dead-ps-pod-sort
branch
from
August 26, 2026 06:09
746eb78 to
64a89a2
Compare
Contributor
Author
|
Updated the pr , title and description accordingly |
Contributor
|
I think it should be sorted by name. Don't forget the e2e tests. |
SortPsOutput already had a "pod" case backed by the psSortedPod sorter, but "pod" was not in the --sort flag's accepted values, so it was rejected before ever reaching the sorter and could never be used. Add "pod" to the accepted values, the shell completion, the invalid-option error message, and the man page so containers can be sorted (grouped) by their pod. Completes the --sort part of the request in podman-container-tools#13033. Signed-off-by: ROKUMATE <rohitkumawat0110@gmail.com>
Create two pods in reverse-alphabetical order, add a container to each, and assert that "podman ps --sort=pod" lists them ordered by pod name. Signed-off-by: ROKUMATE <rohitkumawat0110@gmail.com>
ROKUMATE
force-pushed
the
remove-dead-ps-pod-sort
branch
from
August 26, 2026 13:20
64a89a2 to
9693190
Compare
Contributor
Author
|
@Honny1 Done 👍🏼 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SortPsOutputalready had acase "pod"backed by thepsSortedPodsorter, butpodwas not among the
--sortflag's accepted values (validate.Value), so it was rejectedbefore ever reaching the sorter — the sort option was unreachable. This wires it up by
adding
podto the four surfaces that excluded it: the--sortaccepted values, shellcompletion, the invalid-option error message, and the man page. Completes the
--sortpart of the RFE in #13033 (the
--formatpart already works).Checklist
Ensure you have completed the following checklist for your pull request to be reviewed:
commits. (
git commit -s). (If needed, usegit commit -s --amend). The author email must matchthe sign-off email address. See CONTRIBUTING.md
for more information.
Fixes: #00000in commit message (if applicable)make validatepr(format/lint checks)Noneif no user-facing changes)Does this PR introduce a user-facing change?