Add AnnotationsOr field to hooks schema for OR-matching - #1112
Open
ajoshua2004 wants to merge 1 commit into
Open
Add AnnotationsOr field to hooks schema for OR-matching#1112ajoshua2004 wants to merge 1 commit into
ajoshua2004 wants to merge 1 commit into
Conversation
Hook annotation matching was strictly AND-only , with `Or` field depreciated. AnnotationsOr matches on any single entry, letting a hook combine AND and OR requirements. v1.0.0 and v0.1.0 now forward into v1.1.0, new schema. Signed-off-by: Joshua Arrevillaga <2004jarrevillaga@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
AnnotationsOrto the hookWhenstruct, it behaves similar toAnnotationsbut matches if any single entry matches, instead of requiring all of them. Bumped schema to v1.1.0 and v1.0.0 and v0.1.0 now forward into it viaRead()which is what v0.1.0 used before for v1.0.0Test
go test ./pkg/hooks/...