rootlessnetns: do not pool the unshared thread - #1110
Open
vtushar06 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Tushar Verma <tusharmyself06@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setupMountsunshares the mount namespace, butns.Do()saves and restores only the net namespace and then unlocks the thread, so it goes back to the go scheduler still inside that namespace and later goroutines can run there with the wrong/run.Do()already handles this case for its own failure path, its comment says to leave the thread locked to die. Taking a second lock here means its unlock leaves the count at one, so the runtime scraps the thread when the goroutine ends instead of pooling it.Checked how often a pooled thread actually gets picked up again, by locking a thread, unsharing CLONE_NEWNS, unlocking, then reading /proc/thread-self/ns/mnt from 2000 goroutines:
I have not tied it to a user visible bug,
/is MS_SLAVE so/usrand/etcstay right and only/runis wrong in there.Fixes: #1109