libimage: clarify local image transport error - #1044
Conversation
|
It looks like the Packit job is failing before the build starts due to invalid chroot parameters rather than a build or test failure. Please let me know if there's anything I should update in this PR, or if this is a CI configuration issue. |
mtrmac
left a comment
There was a problem hiding this comment.
Thanks.
The user explicitly asked for a registry image. Nothing suggests the user wants to refer to a local image. In such a situation, sure, the user is probably confused either about what is the operation being attempted, or about what the inputs mean.
But why is it helpful to tell the user how to refer to a local image? That might allow the user to “proceed” without actually clearing up any misunderstandings — potentially resulting in more damage when the user does not understand what is going to happen.
A reminder: https://github.com/podman-container-tools/podman/blob/main/LLM_POLICY.md .
Signed-off-by: Rajkaran Yadav <yadavrajkaran854@gmail.com>
1064940 to
c5f925a
Compare
|
@TomSweeneyRedHat ,Thanks @mtrmac . I’ve addressed the requested change by removing the suggestion to remove the transport prefix. The error now only clarifies that LookupImage supports local-storage image references, without assuming the user’s intent. The corresponding test has also been updated. Could you please take another look when convenient? |
Thanks @mtrmac . I’ve addressed the requested change by removing the suggestion to remove the transport prefix. The error now only clarifies that LookupImage supports local-storage image references, without assuming the user’s intent. The corresponding test has also been updated. Could you please take another look when convenient? |
Summary
Runtime.LookupImage rejects non-storage transport references for local image lookups. The previous error identified the unsupported transport but did not explain how to refer to a locally stored image.
Clarify that the lookup operates on local storage and instruct users to remove the transport prefix while preserving the existing rejection behavior.
Changes
Testing
The focused lookup test was attempted locally but exceeded the execution limit because the existing test pulls Alpine.