Skip to content

storage/overlay: allow native overlay on Lustre in user namespaces #1023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tim-day-387 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

storage/overlay: allow native overlay on Lustre in user namespaces #1023

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion storage/drivers/overlay/overlay.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,6 +319,19 @@ func isNetworkFileSystem(fsMagic graphdriver.FsMagic) bool {
return false
}

func isIdmapNetworkFileSystem(fsMagic graphdriver.FsMagic) bool {
switch fsMagic {
// network file systems with idmapped mounts support...
case graphdriver.FsMagicLUSTRE:
return true
}
return false
}

func isNonIdmapNetworkFileSystem(fsMagic graphdriver.FsMagic) bool {
return isNetworkFileSystem(fsMagic) && !isIdmapNetworkFileSystem(fsMagic)
}

// Init returns the a native diff driver for overlay filesystem.
// If overlay filesystem is not supported on the host, a wrapped graphdriver.ErrNotSupported is returned as error.
// If an overlay filesystem is not supported over an existing filesystem then a wrapped graphdriver.ErrIncompatibleFS is returned.
Expand Down Expand Up @@ -390,7 +403,7 @@ func Init(home string, options graphdriver.Options) (graphdriver.Driver, error)
case graphdriver.FsMagicAufs, graphdriver.FsMagicOverlay, graphdriver.FsMagicEcryptfs:
return nil, fmt.Errorf("'overlay' is not supported over %s, a mount_program is required: %w", backingFs, graphdriver.ErrIncompatibleFS)
}
if unshare.IsRootless() && isNetworkFileSystem(fsMagic) {
if unshare.IsRootless() && isNonIdmapNetworkFileSystem(fsMagic) {
return nil, fmt.Errorf("a network file system with user namespaces is not supported. Please use a mount_program: %w", graphdriver.ErrIncompatibleFS)
}
}
Expand Down
Loading