Skip to content

Handle invalid versions in valid() #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
StantonMatt wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Handle invalid versions in valid() #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion nodesemver/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,7 @@ def parse(version, loose):

def valid(version, loose):
v = parse(version, loose)
if v.version:
if v and v.version:
return v
else:
return None
Expand Down
10 changes: 10 additions & 0 deletions nodesemver/tests/test_regression.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,3 +14,13 @@ def test_it(op, wanted, cands):
from nodesemver import max_satisfying
got = max_satisfying(cands, op, loose=True)
assert got == wanted


@pytest.mark.parametrize("version, loose", [
# https://github.com/podhmo/python-node-semver/issues/42
("NOT VALID", False),
("NOT VALID", True),
])
def test_valid_returns_none_for_unparseable_versions(version, loose):
from nodesemver import valid
assert valid(version, loose) is None