Repository navigation
Conversation
Author
|
I have read the CLA Document and I hereby sign the CLA |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
The regression only checked the generated API definition, so it could miss drift in the Metaculus YAML source.
Change
The test now parses the YAML source and verifies all four GetPosts parameter names and schemas there and in the generated API definition.
Testing
npm test --workspace=pmxt-core -- --runInBand test/exchanges/metaculus-get-posts-params.test.tsfailed on the base spec becauseacting_userwas missing, then passed with the fix.Regression test: fails on base twice (/Expected: ArrayContaining [ObjectContaining {"name": "acting_user"/), passes on fix twice (
npm test --workspace=pmxt-core -- --runInBand test/exchanges/metaculus-get-posts-params.test.ts)Fixes #2615