Repository navigation
Conversation
bercedev
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2530
Closes #2529
handlebars 4.7.9 is in the range of GHSA-p8wg-vrv2-v86f (JS injection via own-property check bypass) and GHSA-8r5x-fm3f-whwj (JS injection via AST type confusion in compile), 4.7.10 fixes both.
handlebars^4.7.8 -> ^4.7.10npm update handlebars --package-lock-only, so the hoisted copy (also used by ts-jest) is now 4.7.10. nothing else in the lockfile movedhandlebars is only used by scripts/generate-api-docs.js, so i ran that with 4.7.9 and with 4.7.10. both give byte-identical sdks/python/API_REFERENCE.md and sdks/typescript/API_REFERENCE.md, and they match what's committed. i didn't run the full jest suite.