Repository navigation
fix(python-sdk): align typed error metadata - #1618
Open
realfishsam wants to merge 1 commit into
Open
realfishsam wants to merge 1 commit into
realfishsam wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Align Python typed-error metadata with the TypeScript SDK by giving directly raised subclasses their specific default error codes and exposing the concrete class through
.name. Explicit wire/server metadata continues to override these defaults.This fixes a coherent cross-SDK error-contract cluster:
RateLimitExceededdefaults.codeto"UNKNOWN_ERROR"instead of"RATE_LIMIT_EXCEEDED"when raised directly #1565ValidationError(and itsMissingWalletAddresssubclass) defaults.codeto"UNKNOWN_ERROR"instead of"VALIDATION_ERROR"when raised directly #1549BadRequest,AuthenticationError,PermissionDenied,NotFoundError,InvalidOrder,InsufficientFunds) default.codeto"UNKNOWN_ERROR"instead of their named code #1528NotSupportederror.codeis"UNKNOWN_ERROR"in Python but"NOT_SUPPORTED"in TypeScript #1422Validation
python3 -m py_compile sdks/python/pmxt/errors.py sdks/python/tests/test_errors.py— passedgit diff --check— passedpmxt_internalartifacts; the focused regression tests are committed for CI.