fix: honor engine exit codes in library verdicts#307
Open
pmatos wants to merge 1 commit into
Open
Conversation
Require successful engine termination before js-sha256, lodash, or luxon can report PASS from a zero-failure summary. This prevents timeouts and crashes after the summary from becoming false passes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
bash -n scripts/libs/js-sha256.sh scripts/libs/lodash.sh scripts/libs/luxon.shcargo fmt --checkcargo clippycargo build --releasecargo test --release./scripts/lint.shTZ=UTC uv run python scripts/run-test262.py— 99,568/99,568 passed, zero regressionsThe host workspace uses Europe/Berlin; an initial unqualified full run exposed 22 pre-existing timezone-sensitive Intl failures. All 22 passed under UTC, and the UTC-normalized full run matched the 100% result recorded in README. No baseline or README update was needed.
Closes #294